RFR(XS): 8191996: VM startup fails with CodeCacheExpansionSize=32768 is outside the allowed range
tobias.hartmann at oracle.com
Tue Nov 28 17:53:48 UTC 2017
thanks for the review! I'll push this directly because the fix is trivial.
On 28.11.2017 18:51, Vladimir Kozlov wrote:
> I don't think we can call a function to set flag value. We use only constants and macros.
Yes, I think so too.
> On 11/28/17 9:32 AM, Tobias Hartmann wrote:
>> please review the following fix:
>> JDK-8179026  set the minimum CodeCacheExpansionSize to vm_page_size() because in CodeCache::initialize() we align to
>> page size anyway. However, there are platforms where the default CodeCacheExpansionSize is 32*K which might be <
>> vm_page_size(). I've fixed this by setting the minimum value to 32*K.
>> A better fix would be to set the default value to os::vm_page_size() (see ) but that would require including
>> runtime/os.hpp which introduces circular dependencies.
>> Thanks to Adrian for reporting this .
>>  http://hg.openjdk.java.net/jdk/hs/rev/7f40c1cdde28
>>  http://cr.openjdk.java.net/~thartmann/8191996/webrev.01/
>>  http://mail.openjdk.java.net/pipermail/hotspot-dev/2017-November/029365.html
More information about the hotspot-compiler-dev