RFR (S): 8191129 - AARCH64: Invalid value passed to critical JNI function
dmitry.chuyko at bell-sw.com
Wed Nov 29 09:13:49 UTC 2017
On 11/29/2017 04:58 AM, dean.long at oracle.com wrote:
> On 11/22/17 6:58 AM, Dmitry Chuyko wrote:
>> Please review a fix for JNI Critical test failures and crashes on
>> aarch64, it includes common tests changes.
>> bug: https://bugs.openjdk.java.net/browse/JDK-8191129
>> webrev: http://cr.openjdk.java.net/~dchuyko/8191129/webrev.00/
>> 1. Platform specific part
>> Original fix from JDK-8167409 was imported, it makes failures more
>> deterministic: Unimplemented() or ShouldNotReachHere().
>> Implementation of the feature is not complete so another change is to
>> forcibly set CriticalJNINatives to false during initialization.
> Do you want to print a warning if the flag was set to true on the
Thanks, I think we should do so.
>> 2. Common part (tests)
>> Tests in criticalnatives read CriticalJNINatives flag using WhiteBox
>> and ignore values check if the flag is false.
> Would "@requires vm.opt.CriticalJNINatives" also work?
It would. But if we don't require it the tests also cover possible
crashes (on ARM).
> The rest looks OK.
>> Both tests pass on x86_64 and aarch64.
More information about the hotspot-compiler-dev