RFR(S) 8189439: Parameters type profiling is not performed from aarch64 interpreter

Andrew Haley aph at redhat.com
Thu Nov 30 13:00:32 UTC 2017

On 30/11/17 12:55, Boris Ulasevich wrote:
> I agree with you on ldrw and excessive tmp1/tmp2. About orptr - yes, we 
> have register conflict on rscratch2 which is used as arg_type pointer in 
> profile_parameters_type and profile_obj_type methods. I have updated 
> orptr to use rscratch1 directly.
> Updated Webrew:
> http://cr.openjdk.java.net/~dchuyko/boris.ulasevich/8189439/webrev.01/

Ah, OK.  That use of arg_type really needs an assert_different_registers
with rscratch1 and the other args.  Please add that, and your patch is
good to go.  Thanks!

Andrew Haley
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671

More information about the hotspot-compiler-dev mailing list