[8u] RFR for backport of JDK-8148175: C1: G1 barriers don't preserve FP registers to jdk8u-dev
erik.osterlund at oracle.com
Thu Oct 12 13:25:52 UTC 2017
Looks good. But...
54: long regionSize = 1_000_000; //WB.g1RegionSize();
Was it intentional to hard code the region size to 1 000 000?
On 2017-10-12 12:46, Muthusamy Chinnathambi wrote:
> May I please get a second review for the change.
> Muthusamy C
> -----Original Message-----
> From: Vladimir Ivanov
> Sent: Wednesday, October 11, 2017 5:29 PM
> To: Muthusamy Chinnathambi <muthusamy.chinnathambi at oracle.com>
> Cc: hotspot-gc-dev at openjdk.java.net; hotspot compiler <hotspot-compiler-dev at openjdk.java.net>
> Subject: Re: [8u] RFR for backport of JDK-8148175: C1: G1 barriers don't preserve FP registers to jdk8u-dev
> Looks good.
> Best regards,
> Vladimir Ivanov
> On 10/11/17 12:33 PM, Muthusamy Chinnathambi wrote:
>> Please review the backport of bug: "JDK-8148175: C1: G1 barriers don't preserve FP registers" to jdk8u-dev
>> Please note that this is not a clean backport due to new entries in TEST.groups and copyright changes.
>> Webrev: http://cr.openjdk.java.net/~mchinnathamb/8148175/webrev.00/
>> jdk9 bug: https://bugs.openjdk.java.net/browse/JDK-8148175
>> Original patch pushed to jdk9: http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/a9334e785873
>> Test: Run jtreg and jprt hotspot testsets.
>> Muthusamy C
More information about the hotspot-compiler-dev