RFR: 8171853: Remove Shark compiler

Roman Kennke rkennke at redhat.com
Sat Oct 14 22:41:05 UTC 2017

The JEP to remove the Shark compiler has received exclusively positive 
feedback (JDK-8189173) on zero-dev. So here comes the big patch to 
remove it.

What I have done:

grep -i -R shark src
grep -i -R shark make
grep -i -R shark doc
grep -i -R shark doc

and purged any reference to shark. Almost everything was straightforward.

The only things I wasn't really sure of:

- in globals.hpp, I re-arranged the KIND_* bits to account for the gap 
that removing KIND_SHARK left. I hope that's good?
- in relocInfo_zero.hpp I put a ShouldNotCallThis() in 
pd_address_in_code(), I am not sure it is the right thing to do. If not, 
what *would* be the right thing?

Then of course I did:

rm -rf src/hotspot/share/shark

I also went through the build machinery and removed stuff related to 
Shark and LLVM libs.

Now the only references in the whole JDK tree to shark is a 'Shark Bay' 
in a timezone file, and 'Wireshark' in some tests ;-)

I tested by building a regular x86 JVM and running JTREG tests. All 
looks fine.

- I could not build zero because it seems broken because of the recent 
Atomic::* changes
- I could not test any of the other arches that seemed to reference 
Shark (arm and sparc)

Here's the full webrev:


Can I get a review on this?

Thanks, Roman

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20171015/90b7acd5/attachment.html>

More information about the hotspot-compiler-dev mailing list