RFR(S) : 8186618 : [TESTBUG] Test applications/ctw/Modules.java doesn't have timeout and hang on windows

Igor Ignatyev igor.ignatyev at oracle.com
Fri Oct 27 02:44:32 UTC 2017

Katya, thank you reviewing it.

can I have another review for this patch from a Reviewer?

-- Igor
> On Oct 26, 2017, at 5:40 PM, Ekaterina Pavlova <ekaterina.pavlova at oracle.com> wrote:
> Looks good.
> Thanks for fixing it,
> -katya
> On 10/17/17 9:45 PM, Igor Ignatyev wrote:
>> http://cr.openjdk.java.net/~iignatyev//8186618/webrev.00/index.html
>>> 546 lines changed: 188 ins; 88 del; 270 mod;
>> Hi all,
>> could you please review this fix for ctw test?
>> in some configurations the test takes too much time, it also didn't have timeout, so in case of a hang, e.g. due to JDK-8189604, no one interrupted its execution.
>>   the fix splits the test into several tests, one for each jigsaw module, which not only improves the tests' reliability and reportability, but also speeds up the execution via parallel execution. 2 hours timeout, which is enough for each particular module, has been added to all tests. the patch also puts ctw for java.desktop and jdk.jconsole modules in the problem list on windows.
>> webrev: http://cr.openjdk.java.net/~iignatyev//8186618/webrev.00/index.html
>> testing: applications/ctw/modules tests
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8186618
>> Thanks,
>> -- Igor

More information about the hotspot-compiler-dev mailing list