[10] RFR: 8189176 - AARCH64: Improve _updateBytesCRC32 intrinsic

Andrew Haley aph at redhat.com
Sat Oct 28 07:52:33 UTC 2017

On 27/10/17 23:31, White, Derek wrote:
>  - The use of temp registers in the UseCRC32 case is kind of muddled, using tmp, and table0..table3 as temp registers, and the name "table" is confusing in this case.
>  - Maybe it would be cleaner to refactor the UseCRC32 code into a separate kernel_crc32_using_crc32() subroutine (static or macro?). This would accept the main args and 4 registers for temps. The caller can supply some combination of table or tmp registers. 
> - This would shrink the size of kernel_crc32() by a lot too.

That would be nice.

Andrew Haley
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671

More information about the hotspot-compiler-dev mailing list