RFR(XS) : 8187020 : AOT tests should not fail if devkit dependency isn't resolved

Igor Ignatyev igor.ignatyev at oracle.com
Sat Sep 2 17:54:37 UTC 2017

> On Sep 2, 2017, at 10:39 AM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
> Indent in new code is wrong. Otherwise looks good.
thank you for review Vladimir.
> So we still don't exit tests gracefully if linker is not found. You still allow JAOTC to try to find linker. But since this test code did not find one JAOTC (which have almost the same code) will not find it either.  You have next change in mind?
yes. should it still be necessary, I'll add @requires property which shows if artifactory resolver can be used, i.e. there is non-default artifactory resolver or at least one java property which are used by default resolver.

-- Igor
> Thanks,
> Vladimir
> On 9/2/17 12:03 AM, Igor Ignatyev wrote:
>> Hi Vladimir,
>> I've added a check that ld -v/-V exits gracefully, compiler/aot tests have been rerun on major platforms.
>> webrev: http://cr.openjdk.java.net/~iignatyev//8187020/webrev.01/index.html
>> incremental: http://cr.openjdk.java.net/~iignatyev//8187020/webrev.00-01/index.html
>> Thanks,
>> -- Igor
>>> On Sep 1, 2017, at 11:21 AM, Vladimir Kozlov <vladimir.kozlov at oracle.com <mailto:vladimir.kozlov at oracle.com>> wrote:
>>> On 9/1/17 11:07 AM, Igor Ignatyev wrote:
>>>> H Vladimir,
>>>> I was planning to add execution of ld -v by a separate patch, but if you want I can merge it into this one.
>>> Yes, please.
>>> Thanks,
>>> Vladimir
>>>> -- Igor
>>>>> On Aug 31, 2017, at 2:12 PM, Vladimir Kozlov <vladimir.kozlov at oracle.com <mailto:vladimir.kozlov at oracle.com>> wrote:
>>>>> On MacOS we also have problem when 'ld' is present on path but Xcode is missing:
>>>>> % /usr/bin/ld -v
>>>>> xcode-select: error: no developer tools were found at '/Applications/Xcode.app', and no install could be requested (perhaps no UI is present), please install manually from 'developer.apple.com <http://developer.apple.com>'.
>>>>> AOT tests will fail in such case too. May be AotCompiler test code also have to execute ld -v (or ld -V on Solaris) to check that we can use linker similar to JAOTC tool:
>>>>> http://hg.openjdk.java.net/jdk10/hs/hotspot/file/a8ec32aa385e/src/jdk.aot/share/classes/jdk.tools.jaotc/src/jdk/tools/jaotc/Linker.java#l104
>>>>> Vladimir
>>>>> On 8/31/17 11:02 AM, Igor Ignatyev wrote:
>>>>>> http://cr.openjdk.java.net/~iignatyev//8187020/webrev.00/index.html
>>>>>>> 11 lines changed: 5 ins; 0 del; 6 mod;
>>>>>> Hi all,
>>>>>> could you please review this tiny fix or AOT tests? Prior this fix, the tests would fail w/ FileNotFoundException when devkit dependency can't be resolved even if jaotc is able to find a linker, e.g. in one of VS*COMNTOOLS. after this fix, if tests aren't able to download devkit, they will allow jaotc to try to find a linker. This patch also remove search for 'ld' in PATH on windows b/c jaotc doesn't use it on windows.
>>>>>> webrev: http://cr.openjdk.java.net/~iignatyev//8187020/webrev.00/index.html
>>>>>> jbs: https://bugs.openjdk.java.net/browse/JDK-8187020
>>>>>> testing: compiler/aot tests
>>>>>> Thanks,
>>>>>> -- Igor

More information about the hotspot-compiler-dev mailing list