RFR: 8214128: arm32: not aligned SP on entry call

Dmitry Samersoff dms at samersoff.net
Sun Dec 2 18:45:46 UTC 2018


Looks good to me.


On 29.11.2018 16:43, Boris Ulasevich wrote:
> Hi all,
> Please review arm32 stack alignment fix.
> http://bugs.openjdk.java.net/browse/JDK-8214128
> http://cr.openjdk.java.net/~bulasevich/8214128/webrev.01
> On arm32 native call with unaligned stack (SP register) does not crash
> immediately, but causes problems far from the point of the entry point.
> In the particular case the problem is in printf malfunction far below on
> the C call stack.
> call() was changed to call_VM_leaf() variant because the latter one
> aligns SP. Save_last_java_pc parameter in set_last_Java_frame() was set
> to true to help vframe unpacker to find CodeBlob.
> Tested with jtreg :tier1.
> Thanks,
> Boris

More information about the hotspot-compiler-dev mailing list