RFR(S)[12] : 8215322 : add @file support to jaotc

Magnus Ihse Bursie magnus.ihse.bursie at oracle.com
Fri Dec 14 11:35:50 UTC 2018

Just a note: If there is no particular reason for jaotc to re-implement 
it's own launcher, it could be using the standard JLI launcher 
framework. There you only need to pass -DENABLE_ARG_FILES during build 
to get @file functionality, apart from all other special case handling 
that's already fleshed out in the standard launcher. All you need to 
provide is the Java class that should be started. In general, I 
recommend all launchers to use this functionality. (I'm guessing the 
current launcher was created, not due to some special circumstances, but 
more due to lack of knowledge about the standard launcher).


On 2018-12-14 01:29, Igor Ignatyev wrote:
> http://cr.openjdk.java.net/~iignatyev//8215322/webrev.00
>> 33 lines changed: 30 ins; 2 del; 1 mod;
> Hi all,
> could you please review this patch for jatoc tool?
> from the bug:
> currently, the number of jaotc argument is limited by max command line length, in some cases, it isn't enough, for example compiling a number of selected classes. many java tools have support for '@file' so adding the same support to jaotc is natural and will solve the problem w/ limitation.Hust o
> I've requested approval per 'Late-Enhancement Request Process' from JEP 3 and will integrate it iif the approval is provided.
> webrev: http://cr.openjdk.java.net/~iignatyev//8215322/webrev.00
> JBS: https://bugs.openjdk.java.net/browse/JDK-8215322
> testing: tier[1-2],hs-tier3-graal
> Thanks,
> -- Igor

More information about the hotspot-compiler-dev mailing list