RFR(S) 8194271: jaotc crashes with --debug flag
tobias.hartmann at oracle.com
Thu Jan 4 07:44:47 UTC 2018
On 03.01.2018 20:50, Igor Veresov wrote:
> That’s a good point. We should. I added a simple test:
Looks good to me!
>> On Jan 3, 2018, at 1:13 AM, Tobias Hartmann <tobias.hartmann at oracle.com <mailto:tobias.hartmann at oracle.com>> wrote:
>> Hi Igor,
>> the fix looks good to me. Should we add --debug to our testing?
>> Best regards,
>> On 03.01.2018 07:02, Igor Veresov wrote:
>>> The change fixes the crash that occurs when jaotc tries to print method disassembly. The problem is that
>>> HotSpotCompiledCodeBuilder.createCompiledCode() assumes that if its method argument is null it’s a stub. And stub
>>> always has a name. The absence of a name caused the crash later on in the C++ code in CodeInstaller::install().
>>> The solution is to pass method name to HotSpotCompiledCodeBuilder.createCompiledCode(). I also strengthened the C++
>>> to throw an exception instead of crashing if a stub doesn’t have a name.
>>> Webrev: http://cr.openjdk.java.net/~iveresov/8194271/webrev.00/
>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8194271
More information about the hotspot-compiler-dev