RFR 11 (S): 8195069: LogCompilation - add basic unit tests

Vladimir Kozlov vladimir.kozlov at oracle.com
Thu Jan 18 23:02:27 UTC 2018

Hi Eric,

Need more explanation about this. How you run the test?

Do you test LogCompilation functionality in JVM or the tool which parse 
log file?

If you want to test the tool why use pre-generated log files? You should 
generate them with latest JVM.


On 1/18/18 2:39 PM, Eric Caspole wrote:
> Hi everybody,
> Could I have reviews for this change which adds very simple junits and 
> more importantly the structure to add better ones later, to help prevent 
> bit rot in LogCompilation.
> JBS: https://bugs.openjdk.java.net/browse/JDK-8195069
> Webrev: http://cr.openjdk.java.net/~ecaspole/JDK-8195069/webrev/
> Thanks,
> Eric

More information about the hotspot-compiler-dev mailing list