RFR(L): 8198691: CodeHeap State Analytics
vladimir.kozlov at oracle.com
Thu Mar 1 20:26:12 UTC 2018
I would say nice work! And nice document. Can you add "general description" (may be shorter version)
as comment to heap.cpp code to avoid looking for document when you want to know how to use it.
May be move new code from heap.* files to new files and to new class (pass CodeHeap as parameter) to
isolate this code. I also would expect to have them in code/ directory and not memory.
Did you try it with AOT libraries? You used FOR_ALL_HEAPS() which includes AOT heaps. May be you
should just use FOR_ALL_ALLOCABLE_HEAPS().
We usually do not add RFE/Bug ID into comments.
I also did not get your placement of PrintCodeHeapState code in "nonproduct" case of
print_statistics(). I would expect it near PrintCodeCache code like in "product" case.
On 3/1/18 9:17 AM, Schmidt, Lutz wrote:
> Dear all,
> may I please request reviews for this quite voluminous enhancement:
> Bug: https://bugs.openjdk.java.net/browse/JDK-8198691
> Webrev: http://cr.openjdk.java.net/~lucy/webrevs/8198691.00/index.html
> Don’t get afraid! Most of the logic is new and isolated in a big, separate block in heap.cpp. The
> changes to other files are not difficult to understand.
> If you need information about what this enhancement does and how it can be used, please refer to the
> bug description. There I have attached some documentation which will greatly help with understanding
> the code.
> Thank you!
More information about the hotspot-compiler-dev