[11] RFR(S): 8198987: [Graal] compiler/intrinsics/sha/sanity tests fail on macos with Graal as JIT

Vladimir Kozlov vladimir.kozlov at oracle.com
Mon Mar 5 17:05:21 UTC 2018



On 3/5/18 6:31 AM, Tobias Hartmann wrote:
> Hi,
> please review the following patch:
> https://bugs.openjdk.java.net/browse/JDK-8198987
> http://cr.openjdk.java.net/~thartmann/8198987/webrev.00/
> Although Graal supports SHA intrinsics [1], the test uses LogCompilation to determine if the
> intrinsics were emitted which is not supported by Graal. Also, the test does not check if the SHA
> intrinsics are actually available. It also fails if C2 is used and the intrinsics are disabled via
> -XX:DisableIntrinsic=_sha_implCompress,_sha2_implCompress,_sha5_implCompress.
> Similar to the mathexact tests (see JDK-8182727), we should use the isIntrinsicAvailable WhiteBox
> API method. It currently always returns false for Graal as JIT (Graal has its own unit tests for
> intrinsics).
> Thanks,
> Tobias
> [1]
> https://github.com/oracle/graal/blob/master/compiler/src/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/meta/HotSpotGraphBuilderPlugins.java#L514

More information about the hotspot-compiler-dev mailing list