RFR 8199603: Build failures after JDK-8199421 "Add support for vector popcount"
tobias.hartmann at oracle.com
Wed Mar 14 11:41:23 UTC 2018
On 14.03.2018 12:33, Aleksey Shipilev wrote:
> With your Reviewer hat on, you consider this trivial? Should I push it now?
I would recommend running this through the submit repo just to make sure.
> On 03/14/2018 12:30 PM, Tobias Hartmann wrote:
>> Hi Aleksey,
>> looks good to me!
>> Best regards,
>> On 14.03.2018 12:18, Aleksey Shipilev wrote:
>>> The problem with the offending change was that the declaration for vpopcntd comes in shared 32/64
>>> assembler, but definition is in 64 assembler only. Assembler method is being used from shared 32/64
>>> x86.ad, so the simplest fix is moving the definition close to shared 32/64, near existing popcntl.
>>> Testing: x86_32 build, x86_64 compiler/vectorization/TestPopCountVector test
>>> (can run it through submit-hs, but I think it is too trivial to bother)
More information about the hotspot-compiler-dev