RFR(XS): 8132287: obsolete the "InlineNotify" flag option
Daniel D. Daugherty
daniel.daugherty at Oracle.com
Thu May 10 17:07:04 UTC 2018
On 5/10/18 12:43 PM, Vladimir Kozlov wrote:
> Looks good.
Thanks for the quick review!
> Only concern is that library_call.cpp does not include
> objectMonitor.hpp. You need to verify build without pre-compiled
> header file.
I should add an include of objectMonitor.hpp. Do you foresee any problem
> On 5/10/18 6:52 AM, Daniel D. Daugherty wrote:
>> This review has been sent to two aliases so please reply to both.
>> I'm obsoleting the '-XX:+InlineNotify' option and moving its
>> to the experimental '-XX:SyncKnobs' option. This is a leftover
>> cleanup from
>> the "Contended Locking fast notify bucket".
>> Since this is a diagnostic option, a CSR is not required:
>> > Interfaces that are experimental or for diagnostic purposes do not
>> > to go through CSR process, but the CSR process may be employed if
>> > from the CSR reviewers is desired.
>> Webrev URL:
>> See the bug for the results of test invocations of the
>> option and the new '-XX:SyncKnobs' suboption.
>> Thanks, in advance, for any feedback.
More information about the hotspot-compiler-dev