RFR(XXS) 8203431: new TestFloatsOnStackDeopt.java test gets error on thread.stop call

Boris Ulasevich boris.ulasevich at bell-sw.com
Tue May 22 11:40:36 UTC 2018

Claes, thanks for the comments.

The test was added to the ProblemList a hour ago. I propose updated 
review with the test being removed from the ProblemList now:



On 22.05.2018 14:20, Claes Redestad wrote:
> Hi,
> On 2018-05-22 13:04, Boris Ulasevich wrote:
>> Hi all,
>> Could you please review simple fix for the recently introduced test
>> http://bugs.openjdk.java.net/browse/JDK-8203431
>> http://cr.openjdk.java.net/~bulasevich/8203431/webrev.02
> the use of a volatile boolean to signal the thread to stop along with 
> Thread.join()
> should be sufficient to make the test well-behaved. Thanks!
> Nit: I'd prefer to see StringBuilder rather than StringBuffer, but don't 
> think that
> this change to avoid string concatenation is necessary in the first 
> place either.
> /Claes

More information about the hotspot-compiler-dev mailing list