RFR(S): 8202747: C2: assert(mode == ControlAroundStripMined && use == sfpt) failed: missed a node

Nils Eliasson nils.eliasson at oracle.com
Thu May 24 09:39:33 UTC 2018

Hi Roland,

I would be nice to clarify the use of extra_data_nodes with a comment. I 
know it was introduced in an earlier patch, but looking at just this 
patch its function was not obvious. Add a comment or change the name to 
something less generic.

Otherwise it looks good, thanks for fixing.

I am testing this together with 8203197 now.


On 2018-05-17 10:48, Roland Westrelin wrote:
> http://cr.openjdk.java.net/~roland/8202747/webrev.00/
> When cloning a strip mined loop nest, verification code catches a data
> node that's not referenced from the safepoint node but is found to be in
> the outer loop. That's caused by another transformation in the same
> round of loop opts that pessimistically assigned control in the outer
> loop to the data node. The fix I propose is to locate those nodes that
> shouldn't be in the outer loop and fix their control during loop
> cloning.
> Roland.

More information about the hotspot-compiler-dev mailing list