RFR: JDK-8213489: GC/C2 abstraction for Compile::final_graph_reshaping()
rkennke at redhat.com
Wed Nov 7 21:40:44 UTC 2018
> + assert(n->is_Mem(), "");
> + MemNode* mem = (MemNode*)n;
> could be replaced with
> + MemNode* mem = n->as_Mem();
Right. I copied existing code from final_graph_reshaping. New changeset
> I don't see removal of moved ZGC code in
Oops, my bad. Fixed.
> Why you skip only assert and not whole switch() (or return) ? Do you
> want to process some nodes twice: by GC first and then in main switch?
Yes. We have a case in Shenandoah where we want to process a CallNode
Shenandoah-specific and then also want to verify/reshape generically.
> May be pass nop (opcode) to final_graph_reshaping() too to avoid virtual
> call Opcode() there.
Thanks for reviewing!
> On 11/7/18 9:00 AM, Roman Kennke wrote:
>> GCs might want to do something to nodes in
>> Compile::final_graph_reshaping(). Let's put an abstraction in this place.
>> The way I did it was to put a call into
>> BSC2::final_graph_reshaping(Compile*, Node*) in front of the huge switch
>> and let the caller know if the node was handled or not. This is
>> subsequently checked in the default-branch: if GC handled it, the
>> asserts are not checked. This should provide the exact same behaviour
>> that we have now, only better and nicer.
>> I also took the opportunity and moved the ZGC related parts there to
>> Testing: hotspot/jtreg:tier1 passes
>> Thoughts? Reviews?
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 833 bytes
Desc: OpenPGP digital signature
More information about the hotspot-compiler-dev