RFR: 8213795: Force explicit null check on patching placeholder offset

Roman Kennke rkennke at redhat.com
Wed Nov 14 11:06:43 UTC 2018

Hi Andrew, Vladimir,

See comment in updated webrev. Does it explain the situation well?



> On 13/11/2018 23:21, Vladimir Kozlov wrote:
>> Originally I just want more detailed comment, nothing more. Current
>> comment is too general.
>> I asked Graal's engineers and they said Graal does not use -1 offset.
>> This is really C1 only "feature".
>> The comment should reflect that.
> Vladimir is right that a comment fingering C1 for this behaviour will be
> enough. Scoping the provenance of those -1 values is the right step #1.
> Fixing the code to show how they actually get lobbed out of that
> particular ball park can be left for a later clean-up.
> So, I'm still ok with the patch once the comment is updated.
> regards,
> Andrew Dinn
> -----------
> Senior Principal Software Engineer
> Red Hat UK Ltd
> Registered in England and Wales under Company Registration No. 03798903
> Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20181114/dd55ae85/signature-0001.asc>

More information about the hotspot-compiler-dev mailing list