RFR (S) 8212070: Introduce diagnostic flag to abort VM on failed JIT compilation

Tobias Hartmann tobias.hartmann at oracle.com
Fri Nov 16 11:09:08 UTC 2018

Hi Aleksey,

On 16.11.18 12:04, Aleksey Shipilev wrote:
>   http://cr.openjdk.java.net/~shade/8212070/webrev.02/

Looks good to me.

> Sorry, I don't quite get this comment. I think the indentation for the flag comment is aligned with
> any other flag comment in that file, including other diagnostic options. There is also a newline
> around new definition.

Right, my bad. I thought the indentation should be

2019   diagnostic(bool, AbortVMOnCompileFailure, false,                          \
2020              "Abort VM when method had failed to compile.")                 \

but now I see that all the flag comments are aligned. The missing newline only affects the 3 CI*
flag definitions before yours but I don't think you need to fix that.


More information about the hotspot-compiler-dev mailing list