[8u-backport] RFR: JDK-8068440: Test6857159.java times out
fairoz.matte at oracle.com
Wed Oct 10 04:00:05 UTC 2018
> -----Original Message-----
> From: Vladimir Kozlov
> Sent: Tuesday, October 09, 2018 11:01 PM
> To: Fairoz Matte <fairoz.matte at oracle.com>; hotspot-compiler-
> dev at openjdk.java.net
> Subject: Re: [8u-backport] RFR: JDK-8068440: Test6857159.java times out
> On 10/9/18 9:07 AM, Fairoz Matte wrote:
> > Hi Vladimir,
> > Thanks for looking into it.
> > Yes no change, I could see in jdk9 it is more structured than jdk8
> > JDK9 - test/compiler/c2/6857159/Test6857159.java
> > JDK8 - test/compiler/6857159/Test6857159.java
> > Wanted to get review to confirm if this directory structure is fine? One
> review is sufficient for this.
> Yes, it should be fine since no packages are used for tests as we do now.
> I noticed that @run shell was removed so the shell file is not needed any
> more. There was followup fix in JDK9 you may consider too because it missed
> exit code check:
I have integrated changes from JDK-8073159
Updated webrev - http://cr.openjdk.java.net/~fmatte/8068440/webrev.01/
As the changes apply cleanly, no further review is required.
Thanks for the review...
> > Thanks,
> > Fairoz
> >> -----Original Message-----
> >> From: Vladimir Kozlov
> >> Sent: Tuesday, October 09, 2018 9:21 PM
> >> To: Fairoz Matte <fairoz.matte at oracle.com>; hotspot-compiler-
> >> dev at openjdk.java.net
> >> Subject: Re: [8u-backport] RFR: JDK-8068440: Test6857159.java times
> >> out
> >> Hi, Fairoz
> >> Reviewed but there no difference from jdk9 fix (except copyright year).
> >> Right? Why need to review?
> >> Regards,
> >> Vladimir
> >> On 10/9/18 8:11 AM, Fairoz Matte wrote:
> >>> Hi,
> >>> Kindly review the backport of " JDK-8068440: Test6857159.java times
> >> to 8u
> >>> Webrev - http://cr.openjdk.java.net/~fmatte/8068440/webrev.00/
> >>> JBS bug - https://bugs.openjdk.java.net/browse/JDK-8068440
> >>> JDK9 changeset -
> >> http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/5bfedd3cfd39
> >>> Review thread -
> >>> http://mail.openjdk.java.net/pipermail/hotspot-compiler-
> >> dev/2015-January/016993.html
> >>> Thanks,
> >>> Fairoz
More information about the hotspot-compiler-dev