[12] RFR(S): 8213014: Crash in CompileBroker::make_thread due to OOM

Doerr, Martin martin.doerr at sap.com
Tue Oct 30 10:43:29 UTC 2018

Hi Tobias,

thanks for fixing. Looks good. Removing the extra bool flag is a nice cleanup.

I'd rate this issue P4 because it's only to get a clean error message instead of a crash when the initial threads don't come up. Right?

Best regards,

-----Original Message-----
From: Tobias Hartmann <tobias.hartmann at oracle.com> 
Sent: Dienstag, 30. Oktober 2018 10:52
To: hotspot compiler <hotspot-compiler-dev at openjdk.java.net>; Doerr, Martin <martin.doerr at sap.com>
Subject: [12] RFR(S): 8213014: Crash in CompileBroker::make_thread due to OOM


please review the following patch:

The code in compileBroker.cpp:806 dereferences 'comp' which is NULL if creation of the sweeper
thread fails. I've also removed the 'compiler_thread' argument and replaced it by a "comp != NULL"
check. In addition, the calls to create_thread_oop() in init_compiler_sweeper_threads() need to
CHECK for exceptions.


More information about the hotspot-compiler-dev mailing list