RFR (XS): 8218937: Make mlvmJvmtiUtils strncpy uses GCC 8.x friendly
mikael.vidstedt at oracle.com
Thu Feb 14 00:38:38 UTC 2019
> On Feb 13, 2019, at 4:12 PM, Igor Ignatyev <igor.ignatyev at oracle.com> wrote:
> Hi Mikael,
> I really don't like us adding goto in cpp code, can we avoid that?
One alternative is to make sure the Deallocate calls are injected in every if statement. I don’t think that’s any better.
Another alternative is to nest the if statements. I’m not a fan of that code style personally.
One could imagine wrapping the resource in a C++ class and have the destructor do the deallocation.
Let me know if you have other suggestions, and/or what you’d prefer.
> I also doubt that any of mlvm tests are run in tier1, could you please also run :vmTestbase_vm_mlvm to test your fix?
> -- Igor
>> On Feb 13, 2019, at 3:45 PM, Mikael Vidstedt <mikael.vidstedt at oracle.com <mailto:mikael.vidstedt at oracle.com>> wrote:
>> Please review this small fix which updates some uses of strncpy to address some GCC 8.x warnings.
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8218937 <https://bugs.openjdk.java.net/browse/JDK-8218937>
>> Webrev: http://cr.openjdk.java.net/~mikael/webrevs/8218937/webrev.00/open/webrev/ <http://cr.openjdk.java.net/~mikael/webrevs/8218937/webrev.00/open/webrev/>
>> GCC 8.2 is producing a warning for mlvmJvmtiUtils.cpp:
>> In file included from test/hotspot/jtreg/vmTestbase/vm/mlvm/indy/func/jvmti/share/libIndyRedefineClass.cpp:31:
>> test/hotspot/jtreg/vmTestbase/vm/mlvm/share/mlvmJvmtiUtils.cpp: In function 'MethodName* getMethodName(jvmtiEnv*, jmethodID)':
>> test/hotspot/jtreg/vmTestbase/vm/mlvm/share/mlvmJvmtiUtils.cpp:80:12: error: 'char* strncpy(char*, const char*, size_t)' specified bound 256 equals destination size [-Werror=stringop-truncation]
>> strncpy(mn->methodName, szName, sizeof(mn->methodName));
>> Basically, gcc is pointing out that the resulting string is not necessarily going to be terminated. Explicitly checking the length of the source strings provides the information needed to guarantee that the strings will be terminated, and silences the warning.
>> Passes tier1.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the hotspot-compiler-dev