RFR(S) : 8218471 : generate-unsafe-access-tests.sh does not correctly invoke build.tools.spp.Spp

Igor Ignatyev igor.ignatyev at oracle.com
Thu Feb 14 03:25:32 UTC 2019

> 63 lines changed: 8 ins; 0 del; 55 mod;

Hi all,

could you please review this small fix for unsafe-access tests generation script and template?

as it is described in 8218460[1], build.tools.spp.Spp's input and output must be specified by -i and -o option, and not as via stdin/stdout.

JdkInternalMiscUnsafeAccessTestObject.java test was changed by 8207146[2] w/o changing the template, hence regenerating tests produces an uncompilable test. this patch includes changes in the template and the script to use Reference instead of Object in method names for Unsafe from jdk.internal.misc.

webrev: http://cr.openjdk.java.net/~iignatyev//8218460/webrev.00/index.html
JBS: https://bugs.openjdk.java.net/browse/JDK-8218471
testing: check that re-generated tests are equal to the current version (modulo copyright years)

[1] https://bugs.openjdk.java.net/browse/JDK-8218460
[2] https://bugs.openjdk.java.net/browse/JDK-8207146

-- Igor

More information about the hotspot-compiler-dev mailing list