RFR(S) : 8218471 : generate-unsafe-access-tests.sh does not correctly invoke build.tools.spp.Spp
igor.ignatyev at oracle.com
Thu Feb 14 19:04:48 UTC 2019
can I get a second review? or ack that the patch is trivial?
> On Feb 14, 2019, at 8:08 AM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
> On 2/13/19 7:25 PM, Igor Ignatyev wrote:
>>> 63 lines changed: 8 ins; 0 del; 55 mod;
>> Hi all,
>> could you please review this small fix for unsafe-access tests generation script and template?
>> as it is described in 8218460, build.tools.spp.Spp's input and output must be specified by -i and -o option, and not as via stdin/stdout.
>> JdkInternalMiscUnsafeAccessTestObject.java test was changed by 8207146 w/o changing the template, hence regenerating tests produces an uncompilable test. this patch includes changes in the template and the script to use Reference instead of Object in method names for Unsafe from jdk.internal.misc.
>> webrev: http://cr.openjdk.java.net/~iignatyev//8218460/webrev.00/index.html
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8218471
>> testing: check that re-generated tests are equal to the current version (modulo copyright years)
>>  https://bugs.openjdk.java.net/browse/JDK-8218460
>>  https://bugs.openjdk.java.net/browse/JDK-8207146
>> -- Igor
More information about the hotspot-compiler-dev