RFR: JDK-8219486: Missing reg_mask_init() breaks x86_32 build

dean.long at oracle.com dean.long at oracle.com
Wed Feb 20 21:23:52 UTC 2019

Does jdk/submit test 32bit?


On 2/20/19 12:41 PM, Roman Kennke wrote:
> JDK-8217909 introduced a method reg_mask_init() which is defined only in
> x86_64.ad, and thus breaks build (linkage) on x86_32.
> I propose to fix this by enclosing the function declaration and call in
> #ifdef _LP64. Alternatively I could add an empty reg_mask_init() to
> x86_32.ad, but I don't like empty code very much. We might want to
> consider to do the with_rbp/no_rbp stuff in x86_32.ad later though. I
> don't have enough time & interest to do it right now.
> Bug:
> https://bugs.openjdk.java.net/browse/JDK-8219486
> Webrev:
> http://cr.openjdk.java.net/~rkennke/JDK-8219486/webrev.00/
> Testing: built 32bit locally, will push through jdk/submit in a minute
> Ok?
> Roman

More information about the hotspot-compiler-dev mailing list