RFR: JDK-8219486: Missing reg_mask_init() breaks x86_32 build
rkennke at redhat.com
Wed Feb 20 21:40:01 UTC 2019
Right. Let's do this then:
> Looks fine.
> For 1-line changes LP64_ONLY() may look better.
> Best regards,
> Vladimir Ivanov
> On 20/02/2019 12:41, Roman Kennke wrote:
>> JDK-8217909 introduced a method reg_mask_init() which is defined only in
>> x86_64.ad, and thus breaks build (linkage) on x86_32.
>> I propose to fix this by enclosing the function declaration and call in
>> #ifdef _LP64. Alternatively I could add an empty reg_mask_init() to
>> x86_32.ad, but I don't like empty code very much. We might want to
>> consider to do the with_rbp/no_rbp stuff in x86_32.ad later though. I
>> don't have enough time & interest to do it right now.
>> Testing: built 32bit locally, will push through jdk/submit in a minute
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 801 bytes
Desc: OpenPGP digital signature
More information about the hotspot-compiler-dev