[aarch64-port-dev ] RFR: 8218748: AARCH64: String::compareTo intrinsic documentation and maintenance improvement
Pengfei Li (Arm Technology China)
Pengfei.Li at arm.com
Fri Feb 22 10:31:22 UTC 2019
> Please review an enhancement change "8218748: AARCH64:
> String::compareTo intrinsic documentation and maintenance improvement".
> RFE: https://bugs.openjdk.java.net/browse/JDK-8218748
> webrev: http://cr.openjdk.java.net/~dpochepk/8218748/webrev/
I still see inconsistencies between the original code block and the documentation. e.g.
1) In macroAssembler_aarch64.cpp, the SHORT_LOOP_TAIL block before the SHORT_LAST2 is missing.
2) And also in macro assembler code, after the SHORT_LOOP label:
+// endReached = cnt2 == 0;
+// if (endReached) goto SHORT_LAST_INIT; --> should it be SHORT_LAST ?
So personally, I still prefer to inline the comments with the original code block to avoid this kind of inconsistencies. And it makes us easier to review or maintain the code together with the doc, as we don't need to scroll back and force. I don't know the benefit of making the code documentation as a separate part. What's your opinion, Andrew Haley?
More information about the hotspot-compiler-dev