RFR (trivial): 8219519: Remove linux_sparc.ad and linux_aarch64.ad
fujie at loongson.cn
Wed Feb 27 05:46:59 UTC 2019
Hi Pengfei and Tobias,
Thank you so much, Pengfei.
The linux_aarch64.ad only defines an enc_class called "Java_To_Runtime"
which is not used in the generation of aarch64's C2 at all.
I think there is no side effect to remove it.
As for the linux_sparc.ad, it is actually empty for the adlc compiler.
It should be safe too.
Tobias, is it still required to test it on the sparc platform?
On 2019/2/27 下午12:15, Pengfei Li (Arm Technology China) wrote:
> Hi Jie, Tobias,
> I (Not-A-Reviewer) tested this change on AArch64. Test result shows "make images" is successful and there's no new jtreg failures after linux_aarch64.ad is removed. But I don't have confidence to say this change has no other side effect.
>> -----Original Message-----
>> From: hotspot-compiler-dev <hotspot-compiler-dev-
>> bounces at openjdk.java.net> On Behalf Of Jie Fu
>> Sent: Wednesday, February 27, 2019 10:25
>> To: Tobias Hartmann <tobias.hartmann at oracle.com>; hotspot-compiler-
>> dev at openjdk.java.net compiler <hotspot-compiler-dev at openjdk.java.net>
>> Subject: Re: RFR (trivial): 8219519: Remove linux_sparc.ad and
>> Hi Tobias,
>> Thanks a lot for your review.
>> It's a bit difficult for me to test this patch since I don't have a sparc or arm
>> I've analyzed the adlc processing logic in
>> make/hotspot/gensrc/GensrcAdlc.gmk finding that ad-files under
>> ARCH) are optional.
>> Since both linux_sparc.ad and linux_aarch64.ad are useless for the
>> generation of C2, it would be better to remove them.
>> I'll try my best to test it.
>> By the way, I really appreciate If someone with sparc or aarch64
>> development environment could help to verify this change.
>> Thanks in advance.
>> Best regards,
>> On 2019/2/27 上午12:51, Tobias Hartmann wrote:
>>> Hi Jie,
>>> this looks good to me assuming that you have tested the change on these
>>> Best regards,
>>> On 21.02.19 10:35, Jie Fu wrote:
>>>> Hi all,
>>>> The following two source files are useless for the generation of C2 and
>> should be removed.
>>>> 1) ./src/hotspot/os_cpu/linux_sparc/linux_sparc.ad
>>>> 2) ./src/hotspot/os_cpu/linux_aarch64/linux_aarch64.ad
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8219519
>>>> Webrev: http://cr.openjdk.java.net/~jiefu/8219519/webrev.00/
>>>> Could you please review it?
>>>> Thanks a lot.
>>>> Best regards,
More information about the hotspot-compiler-dev