RFR(S, tedious): 8217250: Optimize CodeHeap Analytics

Schmidt, Lutz lutz.schmidt at sap.com
Wed Jan 16 20:37:23 UTC 2019

Hi Vladimir, 

thanks a lot for looking at this so quickly. 

Sure, I could declare a specialized "BUFFEREDSTREAM_FLUSH_512" for this. The "512" originated from the thought "its large enough for a well-behaved line and small enough to save some flushes".

I was also thinking about a "BUFFEREDSTREAM_FLUSH_AUTO", where the spare space is derived from the buffer capacity, maybe something like 10 percent of the capacity, 256 bytes minimum. I wasn't sure if that could be categorized as over-engineered. 

Your thoughts?


On 16.01.19, 19:10, "hotspot-compiler-dev on behalf of Vladimir Kozlov" <hotspot-compiler-dev-bounces at openjdk.java.net on behalf of vladimir.kozlov at oracle.com> wrote:

    Hi Lutz,
    I see that you have only one usage in all cases for:
    Can you simple declare simplified macro for this?
    Otherwise looks good.
    On 1/16/19 6:52 AM, Schmidt, Lutz wrote:
    > Dear all,
    > may I please have reviews for this (semantically) small change. Its purpose is to reduce the bufferedStream buffer flushes while printing CodeHeap Analytics.
    > Bug:    https://bugs.openjdk.java.net/browse/JDK-8217250
    > Webrev: http://cr.openjdk.java.net/~lucy/webrevs/8217250.00/
    > Thank you!
    > Lutz

More information about the hotspot-compiler-dev mailing list