[aarch64-port-dev ] RFR: 8217368: AArch64: C2 recursive stack locking optimisation not triggered

Nick Gasson (Arm Technology China) Nick.Gasson at arm.com
Mon Jan 21 09:27:47 UTC 2019

Hi Andrew,

On 21/01/2019 17:10, Andrew Haley wrote:
> On 1/21/19 6:01 AM, Nick Gasson (Arm Technology China) wrote:
>> OK I'll change all three places in aarch64_enc_fast_lock/unlock that do
>> a compare-exchange to use MacroAssembler::cmpxchg.
> If you wish: be aware that if you change anything other than this place there'll
> be a lot more testing to do, and review will take longer.

I think it will be confusing for anyone looking at these functions in 
the future to have one call to cmpxhg and then two copies of essentially 
the same code inlined a few lines afterwards. IMO we should either 
change all three for consistency, or stick with the original minimal 
patch (+ Derek's cleanup suggestions) which should be easier to review.


More information about the hotspot-compiler-dev mailing list