RFR(S): 8215792: AArch64: String.indexOf generates incorrect result

Dmitrij Pochepko dmitrij.pochepko at bell-sw.com
Tue Jan 22 18:35:12 UTC 2019


please take a look at webrev.02: 

webrev.02 has more aarch64 tests and documentation added. Since tests 
are specifically for aarch64 implementation I've set requires tag to run 
it on aarch64 only. I ran these tests on linux-aarch64 machine to 
ensure  everything is fine and on linux-amd64 to ensure these tests are 
filtered out there.

I'm going to add such documentation and tests for other intrinsics as 
well as separate issues.

This patch is for jdk_jdk. I think it should be backported then into 
jdk12 and jdk11u



On 22.01.2019 14:35, Dmitrij Pochepko wrote:
> On 22/01/2019 2:10 PM, Andrew Dinn wrote:
>> On 22/01/2019 10:54, Tobias Hartmann wrote:
>>> On 22.01.19 11:44, Andrew Dinn wrote:
>>>> That's not really needed while we are in Rampdown Phase 1. However, I
>>>> agree that P2 is actually appropriate for this bug.
>>> Actually, it *is* required because we are in Rampdown Phase 2 now:
>>> https://mail.openjdk.java.net/pipermail/jdk-dev/2019-January/002537.html 
>> Oops, yes. Sorry. I just found that post in my Trash folder!
>>> and therefore only P1 and P2 bugs with approval can be integrated:
>>> http://openjdk.java.net/jeps/3
>>>> The fix can be pushed to the jdk12 repo. However, the bug needs to 
>>>> have
>>>> its fix version set accordingly (which I have just done).
>>> Yes and approval is required!
>>> http://openjdk.java.net/jeps/3#Fix-Request-Process
>> Hmm, ok. Well, although this is definitely a bug I don't think it is
>> critical as it happens in relatively rare circumstances. So, I think it
>> needs pushing to jdk13 and then backporting to jdk12 after initial
>> release. I have reset the fix version to jdk13.
> I'll send updated webrev with tests and updated documentation (since I 
> already has it and it doesn't affect code) hopefully in a few hours 
> after final polishing.
> Thanks,
> Dmitrij
>> regards,
>> Andrew Dinn
>> -----------
>> Senior Principal Software Engineer
>> Red Hat UK Ltd
>> Registered in England and Wales under Company Registration No. 03798903
>> Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander

More information about the hotspot-compiler-dev mailing list