RFR (XS) 8220198: Lots of com/sun/crypto/provider/Cipher tests fail on x86_32 due to missing SHA512 stubs

Aleksey Shipilev shade at redhat.com
Tue Mar 26 17:37:52 UTC 2019

On 3/26/19 5:46 PM, Vladimir Kozlov wrote:
> But I would also suggest to add (stubAddr == NULL) check in
> LibraryCallKit::inline_sha_implCompress(). We do such check in other intrinsics [1].

Yes, gracefully returning on uninitialized stub in release bits is a saner behavior. I still want
the assert before that check to catch the actual stubs bug early. Like this:

Still passes tier1. I'll run jdk-submit one more time.

> And please file a new bug to fix other intrinsics which missing the check - I see such cases in library_call.cpp. 



-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20190326/4230197b/signature.asc>

More information about the hotspot-compiler-dev mailing list