RFR: 8256245: AArch64: Implement Base64 decoding intrinsic [v5]

Dong Bo dongbo at openjdk.java.net
Wed Apr 7 06:00:45 UTC 2021

On Tue, 6 Apr 2021 14:04:07 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> Dong Bo has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 10 commits:
>>  - conflicts resolved
>>  - Merge branch 'master' of https://git.openjdk.java.net/jdk into aarch64.base64.decode
>>  - resovling conflicts
>>  - load data with one ldrw, add JMH tests for error inputs
>>  - Merge branch 'master' into aarch64.base64.decode
>>  - copyright
>>  - trivial fixes
>>  - Handling error in SIMD case with loops, combining two non-SIMD cases into one code blob, addressing other comments
>>  - Merge branch 'master' into aarch64.base64.decode
>>  - 8256245: AArch64: Implement Base64 decoding intrinsic
> src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 5800:
>> 5798:     __ br(Assembler::LT, Process4B);
>> 5799: 
>> 5800:     // The 1st character of the input can be illegal if the data is MIME encoded.
> Why is this sentence here? It is very misleading.

This sentence was used to describe the worst case observed frequently so that readers can understand more easily why the pre-processing non-SIMD code is necessary.
I apologize for being unclear and misleading. The annotations have been modified as suggested.


PR: https://git.openjdk.java.net/jdk/pull/3228

More information about the hotspot-compiler-dev mailing list