RFR: 8264795: IGV: Upgrade NetBeans platform
neliasso at openjdk.java.net
Wed Apr 7 08:43:29 UTC 2021
On Tue, 6 Apr 2021 18:34:54 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:
> This change upgrades the NetBeans platform on which IGV is based to its latest version ([12.3](https://netbeans.apache.org/download/nb123/index.html)) and switches IGV's build system from Ant to Maven. The upgrade introduces support for a wide range of JDK versions (from 8 to 15, the latest version supported by NetBeans 12.3), and the switch from Ant to Maven makes the IGV build simpler, faster (first-time build is approximately 5x faster), and more stable (all dependencies are fetched directly from the Maven central repository).
> The change also fixes broken unit tests in the Data module and runs them by default when building.
> #### Testing
> Regression-tested the following use cases manually on all combinations of (Linux, Windows, macOS) and (JDK 8, JDK 11, JDK 15):
> - build
> - open graph file (small.xml in [test-input.zip](https://bugs.openjdk.java.net/secure/attachment/93988/test-input.zip))
> - import graphs via network (localhost)
> - expand groups in outline
> - open a graph
> - open a clone
> - zoom in and out
> - search a node
> - apply filters
> - extract a node
> - show all nodes
> - select nodes corresponding to a bytecode
> - view control flow
> - select nodes corresponding to a basic block
> - cluster nodes
> - show satellite view
> - compute the difference of two graphs
> - change node text
> - remove a group
> - save groups into a file
> - open a large graph file (large.xml in [test-input.zip](https://bugs.openjdk.java.net/secure/attachment/93988/test-input.zip))
> - open a large graph ("After Escape Analysis" in large.xml)
> Thanks to Vladimir Ivanov for helping with testing on macOS.
I have tested IGV on a High-DPI screen (4K). The screens are attached to the bug-report.
Compared to baseline the new version improved DPI scaling on both JDK8 and JDK15. Some elements still doesn't scale.
Remaining issues identified:
1) The default zoom level is to small
2) The filter view has broken scaling - the font scales but not the line height.
3) The buttons above the graph view and file list doesn't scale - they are still tiny.
4) The splash screen doesn't scale
Still this is a big improvement and the remaining issues can be solved in separate PRs.
Looks good - Reviewed!
Marked as reviewed by neliasso (Reviewer).
More information about the hotspot-compiler-dev