RFR: 8264795: IGV: Upgrade NetBeans platform [v2]
Roberto Castañeda Lozano
rcastanedalo at openjdk.java.net
Wed Apr 7 11:59:30 UTC 2021
On Wed, 7 Apr 2021 07:55:58 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:
>> Roberto Castañeda Lozano has updated the pull request incrementally with three additional commits since the last revision:
>> - Document how to build and run on a specific JDK
>> - Use lambdas to define runnables
>> - Document latest JDK version supported
> src/utils/IdealGraphVisualizer/Data/src/main/java/com/sun/hotspot/igv/data/serialization/Parser.java line 154:
>> 152: parent.addElement(group);
>> 153: }
>> 154: };
> You could directly use `Runnable addToParent = () -> parent.addElement(group);` and also for the other ones below.
Good suggestion, thanks, done!
> src/utils/IdealGraphVisualizer/README.md line 10:
>> 8: elements.
>> 10: The tool is built on top of the NetBeans Platform, and requires Java 8 or later.
> Maybe also mention here that the current NetBeans version supports up to JDK 15.
More information about the hotspot-compiler-dev