RFR: 8264063: Outer Safepoint poll load should not reference the head of inner strip mined loop. [v2]

Roland Westrelin roland at openjdk.java.net
Thu Apr 8 12:03:18 UTC 2021

On Wed, 7 Apr 2021 16:05:01 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> When loop is "strip mined" polling address load ([parse1.cpp#L2280](https://github.com/openjdk/jdk/blob/master/src/hotspot/share/opto/parse1.cpp#L2280)) should be cloned together with safepoint node and pinned outside inner loop. Otherwise we have issues like [8263352](https://bugs.openjdk.java.net/browse/JDK-8263352)
>> I also remove leftover (unused needs_polling_address_input() method) from  [8220051](https://bugs.openjdk.java.net/browse/JDK-8220051) changes.
>> Tested hs-tier1-4
> Vladimir Kozlov has updated the pull request incrementally with one additional commit since the last revision:
>   Removed unneeded anymore code in match_fill_loop()

Looks good to me.


Marked as reviewed by roland (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3365

More information about the hotspot-compiler-dev mailing list