RFR: 8264957: Type::dual_type array is not aligned with enum TYPES [v2]

Xiaohong Gong xgong at openjdk.java.net
Tue Apr 13 06:39:18 UTC 2021

> This is a bug fix for [1] which adds a new vector mask type. The new added TYPE `"VectorMask"` is inserted into `enum TYPES`, while the array `"Type::dual_type"` is not updated. This makes the array elements are not aligned with TYPES.
> I met the following crash due to this issue when I was working on the masking feature support on panama-vector:
>  Internal Error (/home/xiagon01/code/panama-vector/src/hotspot/share/opto/type.hpp:1727), pid=104432, tid=104449
>  # assert(_base >= AnyPtr && _base <= KlassPtr) failed: Not a pointer
> Adding a value like other vector types for the `"VectorMask"` in the array `"dual_type"` can fix it.
> [1] https://bugs.openjdk.java.net/browse/JDK-8262355
> Tested with tier1 and jdk:tier3

Xiaohong Gong has updated the pull request incrementally with one additional commit since the last revision:

  Remove array Type::dual_type


  - all: https://git.openjdk.java.net/jdk/pull/3410/files
  - new: https://git.openjdk.java.net/jdk/pull/3410/files/b1c68018..28df8046

 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3410&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3410&range=00-01

  Stats: 44 lines in 2 files changed: 0 ins; 44 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3410.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3410/head:pull/3410

PR: https://git.openjdk.java.net/jdk/pull/3410

More information about the hotspot-compiler-dev mailing list