RFR: 8264957: Type::dual_type array is not aligned with enum TYPES [v2]
jiefu at openjdk.java.net
Tue Apr 13 07:03:04 UTC 2021
On Tue, 13 Apr 2021 06:39:18 GMT, Xiaohong Gong <xgong at openjdk.org> wrote:
>> This is a bug fix for  which adds a new vector mask type. The new added TYPE `"VectorMask"` is inserted into `enum TYPES`, while the array `"Type::dual_type"` is not updated. This makes the array elements are not aligned with TYPES.
>> I met the following crash due to this issue when I was working on the masking feature support on panama-vector:
>> Internal Error (/home/xiagon01/code/panama-vector/src/hotspot/share/opto/type.hpp:1727), pid=104432, tid=104449
>> # assert(_base >= AnyPtr && _base <= KlassPtr) failed: Not a pointer
>> Adding a value like other vector types for the `"VectorMask"` in the array `"dual_type"` can fix it.
>>  https://bugs.openjdk.java.net/browse/JDK-8262355
>> Tested with tier1 and jdk:tier3
> Xiaohong Gong has updated the pull request incrementally with one additional commit since the last revision:
> Remove array Type::dual_type
I didn't find the usage of that array either.
So the change looks fine to me.
I'm afraid the JBS needs to be updated as a cleanup issue.
More information about the hotspot-compiler-dev