RFR: 8262462: IGV: cannot remove specific groups imported via network

Nils Eliasson neliasso at openjdk.java.net
Fri Apr 16 10:12:34 UTC 2021

On Thu, 15 Apr 2021 12:39:09 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

> This change connects groups to their `GraphDocument` parents when the groups are imported via network, making it possible to remove the imported groups later. Before the change, this connection was made only when groups are imported from a file:
> https://github.com/openjdk/jdk/blob/1d66a155c711906fbb5e8e976fd6585ef491ea68/src/utils/IdealGraphVisualizer/Coordinator/src/main/java/com/sun/hotspot/igv/coordinator/actions/ImportAction.java#L147
> Tested manually on JDK 8, 11, and 15 (latest version currently supported by IGV) by following the steps in the [bug report](https://bugs.openjdk.java.net/browse/JDK-8262462).

Looks good! 

You can consider this a 'trivial' change.


Marked as reviewed by neliasso (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3515

More information about the hotspot-compiler-dev mailing list