RFR: 8254129: IR Test Framework to support regex-based matching on the IR in JTreg compiler tests [v2]
chagedorn at openjdk.java.net
Mon Apr 19 12:52:38 UTC 2021
On Thu, 15 Apr 2021 17:49:34 GMT, Igor Ignatyev <iignatyev at openjdk.org> wrote:
> * although having javadoc for testlibraries is highly desirable, I don't think we should check in the generated HTML files
> * the same goes for `README.html` generated from `README.md`
Okay, I will remove them. Does it make sense to still have the HTML files somewhere in the web, for example, on my cr.openjdk?
> * this library is hotspot-centric, I highly doubt that it will be used by any tests outside of the hotspot test base, hence the more appropriate location for it would be inside `test/hotspot/jtreg/testlibrary`.
> * I assume `test/lib/jdk/test/lib/hotspot/ir_framework/tests/` are the tests for the framework, in that case they should be in `test/lib-test`, if we stick to `test/lib` as the location for the library, or in `test/hotspot/jtreg/testlibrary_tests`, if we move it to `test/hotspot`
That makes sense to move everything to `test/hotspot/jtreg/testlibrary`. Right, the `test/lib/jdk/test/lib/hotspot/ir_framework/tests/` are only tests for the framework itself and should not be run as part of tier testing each time (does not make much sense) but only when the framework is actually modified. Is this still the case when putting them in `test/hotspot/jtreg/testlibrary_tests` (i.e. not executed unless run manually)?
I will do this things in a separate commit and adjust the README.md file accordingly (has links to the Javadoc files).
More information about the hotspot-compiler-dev