RFR: 8262725: IGV: crash when removing all graphs in a group
rrich at openjdk.java.net
Mon Apr 19 13:08:35 UTC 2021
On Fri, 16 Apr 2021 09:11:30 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:
> This change makes IGV close graph views when their groups are either a) removed or b) emptied (all graphs are removed but the group remains), and avoids faulty graph view computation in case b).
> Tested the following scenarios manually (on groups loaded both via network and from a file, and on JDK 8, 11, and 15):
> 1. open a graph, then remove all graphs in the group (as described in the [bug report](https://bugs.openjdk.java.net/browse/JDK-8262725));
> 2. open a graph, then remove its group; and
> 3. open a graph, then remove all graphs and groups (File -> Remove all graphs and groups).
thanks for providing the fix. I've built and tested it successfully as described in the bug report [JDK-8262725](https://bugs.openjdk.java.net/browse/JDK-8262725). Your fix seems to solve this issue.
I'm still not able to remove the empty group `virtual void java.lang.Object.<init>()` as additional last step though.
Does this work for you?
More information about the hotspot-compiler-dev