RFR: 8262725: IGV: crash when removing all graphs in a group [v2]
rrich at openjdk.java.net
Mon Apr 19 14:00:45 UTC 2021
On Mon, 19 Apr 2021 13:28:20 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:
>> This change makes IGV close graph views when their groups are either a) removed or b) emptied (all graphs are removed but the group remains), and avoids faulty graph view computation in case b).
>> Tested the following scenarios manually (on groups loaded both via network and from a file, and on JDK 8, 11, and 15):
>> 1. open a graph, then remove all graphs in the group (as described in the [bug report](https://bugs.openjdk.java.net/browse/JDK-8262725));
>> 2. open a graph, then remove its group; and
>> 3. open a graph, then remove all graphs and groups (File -> Remove all graphs and groups).
> Roberto Castañeda Lozano has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> - Simplify listener registration
> - Merge branch 'master' into JDK-8262725
> - Close graph views when their groups are removed or emptied
I've tested the fix and found it solves the issues.
(Cannot really comment on the change itself as I'm not familiar with igv implementation / netbeans).
Marked as reviewed by rrich (Reviewer).
More information about the hotspot-compiler-dev