RFR: 8254129: IR Test Framework to support regex-based matching on the IR in JTreg compiler tests [v2]

Igor Ignatyev iignatyev at openjdk.java.net
Mon Apr 19 17:03:38 UTC 2021

On Fri, 16 Apr 2021 02:14:35 GMT, Igor Ignatyev <iignatyev at openjdk.org> wrote:

>> Christian Hagedorn has updated the pull request incrementally with one additional commit since the last revision:
>>   Adjust whitelist
> test/lib/jdk/test/lib/hotspot/ir_framework/AbstractInfo.java line 41:
>> 39:  */
>> 40: abstract public class AbstractInfo {
>> 41:     private static final Random random = new Random();
> you shouldn't use Random w/o predefined seed as it might make it harder to reproduce, please consider using `jdk.test.lib.Utils.getRandomInstance` or `jdk.test.lib.RandomFactory.getRandom` here

I've also noticed that you use `Collections::shuffle` in `TestFrameworkExecution` w/o passing a reproducible rng.


PR: https://git.openjdk.java.net/jdk/pull/3508

More information about the hotspot-compiler-dev mailing list