RFR: 8265403: consolidate definition of CPU features [v3]
dnsimon at openjdk.java.net
Mon Apr 19 19:42:05 UTC 2021
On Mon, 19 Apr 2021 18:58:46 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:
>> Doug Simon has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
>> avoid use of a lambda in JVMCI initialization
> src/hotspot/cpu/x86/vmStructs_x86.hpp line 45:
>> 44: #define DECLARE_LONG_CPU_FEATURE_CONSTANT(id, name, bit) GENERATE_VM_LONG_CONSTANT_ENTRY(VM_Version::CPU_##id)
>> 45: #define VM_LONG_CPU_FEATURE_CONSTANTS CPU_FEATURE_FLAGS(DECLARE_LONG_CPU_FEATURE_CONSTANT)
> Do we need to keep `VM_LONG_CONSTANTS_CPU` after you removed its body here and in vmStructs_jvmci.cpp?
> What about `VM_INT_CONSTANTS_CPU` here? vmStructs_jvmci.cpp duplicates it.
`vmStructs.cpp` and `vmStructs_jvmci.cpp` are disjoint. This file (i.e. `vmStructs_x86.hpp`) is only used by `vmStructs.cpp`.
`vmStructs.cpp` expects all macros such as `VM_LONG_CONSTANTS_CPU` to be defined.
`vmStructs_jvmci.cpp` will provide a dummy definition for missing macros.
More information about the hotspot-compiler-dev