RFR: 8254129: IR Test Framework to support regex-based matching on the IR in JTreg compiler tests [v2]
iignatyev at openjdk.java.net
Mon Apr 19 23:36:14 UTC 2021
On Mon, 19 Apr 2021 09:37:40 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:
>> you might also want to update javadoc for this method to state that there can be duplicates.
> Have I understood this correctly that you suggest to just remove this check completely and just specifying in the Javadocs that duplicates are ignore (due to using a `Set`)?
you don't have to ignore duplicates, you can still throw an exception if you encounter one. I, personally, don't think we should force users to avoid dups (as I don't yet? see any issues w/ duplicated helpers), but if you think we need to enforce that *and* make it users' responsibilities then you should continue to throw an exception. in both cases, javadoc should be updated to reflect that duplicates are ignored or that an exception is raised in case a duplicate was encountered.
More information about the hotspot-compiler-dev