RFR: 8254129: IR Test Framework to support regex-based matching on the IR in JTreg compiler tests [v3]

Christian Hagedorn chagedorn at openjdk.java.net
Tue Apr 20 13:41:09 UTC 2021

On Mon, 19 Apr 2021 20:52:31 GMT, John Tortugo <github.com+2249648+JohnTortugo at openjdk.org> wrote:

>> Christian Hagedorn has updated the pull request incrementally with one additional commit since the last revision:
>>   Apply review comments in code from Igor I. and Vladimir K.
> test/lib/jdk/test/lib/hotspot/ir_framework/README.md line 110:
>> 108: 
>> 109: The framework will spawn a new "test VM" to execute the user defined tests. The test VM collects all tests of the test class specified by the user code in `main()` and ensures that there is no violation of the required format by the framework. In a next step, the framework does the following for each test in general:
>> 110: 1. Warm the test up for a predefined number of times (default 2000). This can also be adapted for all tests by using `testFrameworkobject.setDefaultWarmup(100)` or for individual tests with an additional [@Warmup](./doc/jdk/test/lib/hotspot/ir_framework/Warmup.html) annotation. 
> The previous section seems to indicate that the default number of warm-up iterations is 200. "-Dwarmup=200".

I added a comment in section 2.5 mentioning the framework default of 2000 to avoid confusions.


PR: https://git.openjdk.java.net/jdk/pull/3508

More information about the hotspot-compiler-dev mailing list