RFR: 8265491: Math Signum optimization for x86 [v2]

Marcus G K Williams github.com+168222+mgkwill at openjdk.java.net
Wed Apr 21 16:23:38 UTC 2021

On Wed, 21 Apr 2021 06:38:54 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Marcus G K Williams has updated the pull request incrementally with one additional commit since the last revision:
>>   Add os.arch=="i386" to signum jtreg
>>   Signed-off-by: Marcus G K Williams <marcus.williams at intel.com>
> test/hotspot/jtreg/compiler/intrinsics/math/TestSignumIntrinsic.java line 28:
>> 26:  * @test
>> 27:  * @summary Test compiler intrinsics for signum
>> 28:  * @requires os.arch=="aarch64" | os.arch=="x86" | os.arch=="i386" | os.arch=="amd64" | os.arch=="x86_64"
> Shouldn't this test run successfully on all platforms, even if they don't do anything in response to UseSignumIntrinsic? I can run it today on x86_64.

Hi @dholmes-ora. I have not done negative testing on any platform using TestSignumIntrinsic.java. I'm not the original author, but what you say makes sense after some thought. I'll try an easy test, remove this line and see if presubmit tests pass.


PR: https://git.openjdk.java.net/jdk/pull/3581

More information about the hotspot-compiler-dev mailing list