RFR: 8265480: add basic JVMCI support for JEP 309: Dynamic Class-File Constants [v2]
psandoz at openjdk.java.net
Wed Apr 21 20:26:10 UTC 2021
On Wed, 21 Apr 2021 19:57:05 GMT, Doug Simon <dnsimon at openjdk.org> wrote:
>> This PR adds support to JVMCI for CONSTANT_Dynamic constant pool entries. It brings the JVMCI support on par with the support in CI for C1 and C2 with one difference: JVMCI will resolve unresolved condy entries where as CI bails out in this case (it expects condy entries to be resolved by the interpreter).
>> When using JVMCI for JIT compilation, unresolved entries should only be seen when running under -Xcomp.
>> When using JVMCI for AoT (e.g. Native Image), most entries will be unresolved since no other code apart from the AoT compiler is running.
> Doug Simon has updated the pull request incrementally with one additional commit since the last revision:
> fixed date in copyright headers
src/hotspot/share/jvmci/jvmciCompilerToVM.cpp line 659:
> 657: }
> 659: JVMCIObject result = JVMCIENV->call_PrimitiveConstant_forTypeChar(type2char(bt2), raw_value, JVMCI_CHECK_NULL);
Given the above switch is total this part is unreachable? Did you mean for it to occur after the `if (!is_reference_type(bt)) ` block?
More information about the hotspot-compiler-dev